fac28 / code-reviews

0 stars 0 forks source link

monsters inc - code review #6

Open ShaughnAnderson94 opened 1 year ago

ShaughnAnderson94 commented 1 year ago

README

[Does the README describe the project using the subheadings: Why?, What?, How? i.e. Why have you created this repo, what does it do, how does it do it?]

README is very helpful in getting the site open but does not have the why what how. Also link is not descriptive

User stories

[Does the project meet the user stories for that week?] Yeah it would work as a site for this agency and has fun character.

Learning outcomes

[Does it demonstrate the learning outcomes for that week?] It shows good use of css and the forms part works. Some small confusing parts with screen reader

UI bugs

[Can you see any obvious bugs or areas to improve?]

UI is good add a home link to site logo

Instructions

[Does everything work as expected or were there missing instructions?] Everything is clear for the most part

File structure

[When you open the project in your editor, does the file structure make sense?] Yes all clear Id not seen components.js before but it made sense when I saw it

Flow of control

[ Can you you follow the different paths the code might take?] yeah

Naming

[Do variables and functions have clear and descriptive names?] Yes

Readability

[Do you understand the code?] for the most part the resizing changes dont seem as visible as the volume of code would suggest.