fac28 / in-house-project

https://in-house-project.vercel.app
0 stars 1 forks source link

Roots-review #29

Open tess-phillips opened 11 months ago

tess-phillips commented 11 months ago

Live laugh love the background and carousels of the main page

No husky :( Lots of css files, why u no use tailwind only? interesting love that you have jest installed for unit testing. if you want to install playwright i can help (also you may need to tell jest to only look at jest and same for playwright, https://playwright.dev/docs/intro this link is waaaay better than the next installation guide)

sgroi-l commented 11 months ago

Hey gang, this look like it's gonna be sick. I have nothing interesting to tell you sorry, it looks like you haven't set up your eslintrc.json to have anything other than default values and you don't have prettier to enforce anything either.

here's ours for example.

{
  "extends": ["airbnb", "plugin:@next/next/recommended"],
  "plugins": ["prettier"],
  "rules": {
    "prettier/prettier": "error"
  },
  "settings": {
    "react": {
      "version": "detect"
    }
  }
}