search

fac30sb / agency-website--Ollie-Emma

Project for the Markup module
0 stars 0 forks source link

Added main element styling #12

Closed zz-hh-aa closed 10 months ago

zz-hh-aa commented 10 months ago

Added elements styles listed in the "create CSS styling" card (closes #10).

No HTML has been touched yet--so will need to add the classes there and start testing layout.

electricblues commented 10 months ago

Hey, how about we focus on the overall page styling for now and add CSS/JS for individual features as we move along? Your CSS has some styling for the whole page, maybe there would be useful l to have some basic fonts / make the colours from the colour palette that you worked with into css variables so we can use them from there on where needed.

Alternatively, we could use your CSS as a base, integrating it with the HTML elements, and then tackle each feature modularly - we just need to be mindful of merge conflicts from then on by sticking to the HTML/CSS/JS related to each feature.

I'm going to hold off on merging this pull request until I get your input on this idea.

zz-hh-aa commented 10 months ago

I think approach 2 should work--(using CSS as base, integrating it with HTML and then continue feature by feature).

This is ready for review again--there are quite a few obvious issues from the get go, but will create separate issues for them. This should close #11 too.