search

facade / ignition-code-editor

Add inline code editing to your ignition page
http://flareapp.io/docs/ignition-for-laravel/first-party-extensions#ignition-code-editor
MIT License
44 stars 5 forks source link

refacto: improves if/else statement within service provider #11

Closed nunomaduro closed 4 years ago

nunomaduro commented 4 years ago

This pull request improves if/else statement within service provider.

Note: I didn't test this code locally.

freekmurze commented 4 years ago

Thank you for this PR, Nuno, but I like the current implementation better. It's easier to debug (you can set easily set breakpoints on the individual conditations) and I find this to be more readable (that's a bit subjective of course).

nunomaduro commented 4 years ago

Got it!