Quotes unproperly highlit in Linux

[immjs]

Describe the bug Quotes are unproperly highlit for JS: opening a singlequote or a doublequote causes the rest of the line to be colored in quotes

To Reproduce Steps to reproduce the behavior:

1. Create a JavaScript (not sure if exclusive to JS) file
2. Type (Minimal reproducible example, among others):

   console.log('hello' + 54321);
   console.log("hello" + 54321);
   console.log(54321);

Expected behavior The 54321 should have the same color everywhere, so should the parentheses

Screenshots

Desktop (please complete the following information):

• OS: Arch Linux
• Version v1.2.0

[ItsTato]

Cannot replicate in 1.2.0

With the example code you left:

[immjs]

Just curious, are you running under Linux or Windows (or was it self-built)? It could be that the binary shipped for Linux includes a version of godot with a broken lineonly

Cannot replicate in 1.2.0

With the example code you left:

[ItsTato]

Howdy. It was on Windows, gimmie a sec to just put my linux out of suspend and try it real quick. (Still convinced it's 100% a issue on your end though)

[immjs]

Ok! For future reference, my linux release has v4.2.1.stable.official.b09f793f5 as the godot engine version

[ItsTato]

Apologies for doubting you, it seems you were correct.

Linux version is indeed broken. #99 seems to speak about this but the author decided to leave no words. I'll link this issue there

[immjs]

Apologies for doubting you, it seems you were correct.

Linux version is indeed broken. #99 seems to speak about this but the author decided to leave no words. I'll link this issue there

It's all good! Sorry for bothering you further, but I'll try to dig it up a bit: what's the godot engine version for your windows build?

[ItsTato]

No idea, sorry :p

[Symmettry]

Perhaps rename issue to "Syntax highlighting broken on linux"? (unless that's not the topic but that's what i'm reading at least)

[face-hh]

Can confirm it only works improperly on Linux.

I'm wondering why that is...

https://github.com/face-hh/griddycode/blob/6332a66671952a79cea4ea824b783f231fd9f67c/Scripts/settings.gd#L66-L69

This is where the magic happens. To debug this I'd suggest logging the entry, running GriddyCode, and entering a JavaScript file. Then compare the printed results on Linux and Windows.

[immjs]

I was able to reproduce the bug on Windows with rendering driver opengl3 - maybe that's the issue?

The only Windows PC I have is not performant enough to run it from DirectX, maybe someone who's downloaded it from the Releases folder could triple-check for DX as well?

[tovade]

i have this issue on windows too, not just linux

[Symmettry]

Weird; i don't have it

[KisenaMiyuki]

Windows here I don't have this issue in empty files

But do when in a proper js file

[immjs]

Windows here I don't have this issue in empty files

But do when in a proper js file

i believe its because it doesn't think you're in js inside the first file, hence it doesn't apply the quotes magic

you can see the dash is colored differently from the other text in the quotes