search

face-hh / griddycode

A code editor made with Godot. Code has never been more lit!
Apache License 2.0
1.82k stars 115 forks source link

Add go plugin + Kanagawa theme (Light Mode, Dark Mode) #43

Closed zSnails closed 8 months ago

zSnails commented 8 months ago

Pretty much what the title says, let me know if I missed anything

zSnails commented 8 months ago

I was going to add the plugin and both themes in their own pull request, but things happened, and I ended up uploading the dark theme to this branch as well, oh well

Symmettry commented 8 months ago

to_list function is useless. Just table.insert(table, match) instead of table[match] = match

zSnails commented 8 months ago

@Symmettry I did that to avoid repeating function and variable names on the autocomplete menu

With the to_list workaround. image

Without the to_list workaround image

Symmettry commented 8 months ago

Just check if the list doesn’t have it?

zSnails commented 8 months ago

@Symmettry well you could do it that way, although that'd be a bit slow wouldn't it? :^), checking if the list doesn't have it will be O(n), with this method it's always O(1), and yes, I know that this is just a toy editor and that no one's using this for actual coding, just stating why I did it, I'll change it

Symmettry commented 8 months ago

Or you could also ignore it anyway. I feel it might be better if GriddyCode itself dealt with repeats.

zSnails commented 8 months ago

Yeah that'd be a lot better, but having the same name show up 7 times in the autocomplete menu is kinda whack, I could open an issue and discuss that.

Having LSP support would be the next logical step, but I can't help with that as I don't have that much free time to work on it.