faceair / atom-goto-definition

⚠️⚠️⚠️ DEPRECATED
https://atom.io/packages/goto-definition
GNU General Public License v2.0
99 stars 51 forks source link

Interferes w/ hyperlink-hyperclick #49

Closed black-snow closed 7 years ago

black-snow commented 7 years ago

Sadly, for some months now, goto-definition seems to interfere with hyperlink-hyperclick.

With goto-definition disabled URLs get highlighted correctly and hyperlink works as expected. With goto-definition enabled just parts of the URL get highlighted, there's no way to click+open any URLs. It sometimes works when disabling and re-enabling both plugins in some magic order.

faceair commented 7 years ago

https://atom.io/packages/hyperclick

Hyperclick only returns suggestions from a single provider, and provide an option priority to override others. You can send an pull request to hyperlink-hyperclick, set priority before main.js#92L. goto-definition not set priority, the default value is 0, hyperlink-hyperclick's priority should be greater than it.

black-snow commented 7 years ago

@faceair thanks