search

faceair / atom-goto-definition

⚠️⚠️⚠️ DEPRECATED
https://atom.io/packages/goto-definition
GNU General Public License v2.0
99 stars 51 forks source link

Detect language based on editor current syntax mode #56

Open kirly-af opened 7 years ago

kirly-af commented 7 years ago

It would be great it the plugin could rely on the editor's mode to know which language is used.

Let's say you're editing a JS file without extension, the plugin currently can't detect JS even though the editor is in JS syntax mode.

faceair commented 7 years ago

If user use some language enhanced syntax package, we can't know it's real language. Some like Magic Python language-javascript-better and so on. The file extension is more general way.

faceair commented 7 years ago

See #9

kirly-af commented 7 years ago

I am not saying it should exclusively rely on the syntax, but it could be the "last try" before giving up with the "language not supported" message. I don't think that'd a lot of work to implement.

Concerning #9, I'm afraid my Chinese skills are below your expectations 😜

faceair commented 7 years ago

Maybe this is a good solution, I will try.