search

faceair / atom-goto-definition

⚠️⚠️⚠️ DEPRECATED
https://atom.io/packages/goto-definition
GNU General Public License v2.0
99 stars 51 forks source link

Duplicate results in Performance mode #67

Open Olie440 opened 7 years ago

Olie440 commented 7 years ago

When performance mode is turned on and the definition is in an open file atom shows the same result twice: image

Looking into it it appears to be caused by ripgrep not ignoring absolute paths: image

I have fixed this locally by removing the atom buffer scan, and am happy to make a PR. However this has the side effect of excluding files outside the project. Although that would be an edge case I thought I raise it anyway.

I have also raised this issue on the ripgrep repo: https://github.com/BurntSushi/ripgrep/issues/479

jbazin30 commented 7 years ago

Hello, I am interested in knowing how to remove the atom buffer scan. I'm novice with packaging edition in Atom.

Thx

Edit :

Based on your issue BurntSushi/ripgrep#479 it's work with this : return filePath.split("/").pop(); on line 56 in ~/.atom/packages/goto-definition/lib/searcher.js