search

facebook-adblock / facebook_adblock

An open-source Ad Blocker for Facebook™
GNU General Public License v3.0
214 stars 42 forks source link

[Feature] Sponsored Marketplace ads not suppressed #107

Open Kronzky opened 2 years ago

Kronzky commented 2 years ago

Environment

Describe the bug Sponsored ads on Marketplace are not blocked.

Screenshots of console https://imgur.com/5XlUrFN

To Reproduce Steps to reproduce the behavior:

  1. Go to 'Marketplace'
  2. Scroll down a few pages
  3. Sponsored ads show up

Expected behavior Sponsored ads should be hidden (most of them are scams)

cbotsikas commented 2 years ago

Marketplace ads are not detected, that would be a new feature. Contribution is welcome

Dark3n89 commented 2 years ago

Marketplace ads are not detected, that would be a new feature. Contribution is welcome

Hi i make today work script for delete ads from marketplace and marketplace/category how i can share? Will you add into your code?

tiratatp commented 2 years ago

Marketplace ads are not detected, that would be a new feature. Contribution is welcome

Hi i make today work script for delete ads from marketplace and marketplace/category how i can share? Will you add into your code?

You can send a pull request (PR), https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/about-pull-requests

Dark3n89 commented 2 years ago

Environment

  • Extension version: 1.9.5
  • Browser and version: Brave (Chromium) 1.31.87
  • OS and version: Win10 21H1

Describe the bug Sponsored ads on Marketplace are not blocked.

Screenshots of console https://imgur.com/5XlUrFN

To Reproduce Steps to reproduce the behavior:

  1. Go to 'Marketplace'
  2. Scroll down a few pages
  3. Sponsored ads show up

Expected behavior Sponsored ads should be hidden (most of them are scams)

is it only first BETA but i add my code to this code and marketplace is clean userscript

tiratatp commented 2 years ago

Environment

  • Extension version: 1.9.5
  • Browser and version: Brave (Chromium) 1.31.87
  • OS and version: Win10 21H1

Describe the bug Sponsored ads on Marketplace are not blocked. Screenshots of console https://imgur.com/5XlUrFN To Reproduce Steps to reproduce the behavior:

  1. Go to 'Marketplace'
  2. Scroll down a few pages
  3. Sponsored ads show up

Expected behavior Sponsored ads should be hidden (most of them are scams)

is it only first BETA but i add my code to this code and marketplace is clean userscript

Good start. Let me take a look.

tiratatp commented 2 years ago

Environment

  • Extension version: 1.9.5
  • Browser and version: Brave (Chromium) 1.31.87
  • OS and version: Win10 21H1

Describe the bug Sponsored ads on Marketplace are not blocked. Screenshots of console https://imgur.com/5XlUrFN To Reproduce Steps to reproduce the behavior:

  1. Go to 'Marketplace'
  2. Scroll down a few pages
  3. Sponsored ads show up

Expected behavior Sponsored ads should be hidden (most of them are scams)

is it only first BETA but i add my code to this code and marketplace is clean userscript

I looked at the code. In our extension, I tried to consider performance when blocking things. That's why we don't use setInterval here but use mutation observer https://developer.mozilla.org/en-US/docs/Web/API/MutationObserver.

Another feedback is that the obfuscated class name are not a good filter since they change often.