search

facebook-adblock / facebook_adblock

An open-source Ad Blocker for Facebook™
GNU General Public License v3.0
215 stars 42 forks source link

[BUG] ads in my timeline, again #125

Closed Conan179 closed 2 years ago

Conan179 commented 2 years ago

hi, just wanted to let you know that the advertising and the "Sponsored" box at the top right are back.

dima6526 commented 2 years ago

same here...

AlgorithMan-de commented 2 years ago

same here. I don't know how it worked before, but I have examined the "Gesponsert"-tag (german) and I noticed that facebook obfuscates the text in there. There was a <span> with 42 sub-spans, which contained one character each. They were in random order, but the spans have style="order: ..." which puts them in the correct order. Also there are additional characters, which I guess are made invisible via the class attribute.

I'll attach a file with the exported HTML Element after sorting the spans by their style="order:..." tags. In the last line, I have extracted the characters and highlight the "G", "e", "s", "p", "o", "n", "s", "e", "r", "t" in there. facebook_ads.txt

I don't think it's necessary to decrypt the text, since the "sponsored" boxes seem to be the only timeline elements that have so many sub-tags.

isaactzab commented 2 years ago

I made a fix that probably solve the problem in your language. Please check it out. It currently works for spanish facebook.

Dark3n89 commented 2 years ago

I made a fix that probably solve the problem in your language. Please check it out. It currently works for spanish facebook.

I rewrite by your changes and all now work perfect, BIG thank you BOSS ♥ image

isaactzab commented 2 years ago

awesome! Hopefully, the PR will be approved. @tiratatp Let me know if any additional adjustments are needed to this PR

tiratatp commented 2 years ago

awesome! Hopefully, the PR will be approved. @tiratatp Let me know if any additional adjustments are needed to this PR

Thank you for the fix @isaactzab ! Posted one minor comment. Could you fix that and I can merge it today?

tiratatp commented 2 years ago

Released as v1.9.11

Thanks all!

Conan179 commented 2 years ago

On the german facebook site, its not working.

Conan179 commented 2 years ago

fa_190622

isaactzab commented 2 years ago

I tried to replicate and indeed, in the Spanish version the advertisement came up again. I did npm install, then npm run release, reloaded the extension and it worked fine. The advertisement is gone. Probably you have some issue with the build.

isaactzab commented 2 years ago

I am not sure if the chrome extension store version is the same as the repository version. can you confirm that @tiratatp ?