search

facebook-adblock / facebook_adblock

An open-source Ad Blocker for Facebook™
GNU General Public License v3.0
215 stars 42 forks source link

Sponsored ad got through on 1.9.3 in Chrome #95

Closed pa28236 closed 3 years ago

pa28236 commented 3 years ago

All was good, then I just saw this Sponsored ad. Running 1.9.3 in Chrome. Still, better than it was in 1.9.2 for me. Now...to get rid of all the "Suggested for You" ads!

image

tiratatp commented 3 years ago

I think this is because I forgot to include #89 in 1.9.3.

You only see political ads like this right?

dfayruzov commented 3 years ago

I'm waiting for get rid of "suggested for you" ads too. In the meanwhile: switching to Most Recent tab restores "sponsored" ads (and yes, they are NOT political ads).

First time here - if it's needed, just tell me - I'll reopen as new bug. image

jmccl commented 3 years ago

I'm also getting sponsored (non-political) ads on Chrome Version 90.0.4430.85

Screenshot_2021-04-28_08-36-31

SanskritFritz commented 3 years ago

Same problem on Firefox, version 1.9.3

Screenshot_20210520_170520

offroadpaparazzi commented 3 years ago

seeing this in facebook.com/watch ( ad every 5th post)

watch

haidang666 commented 3 years ago
Screen Shot 2021-05-28 at 11 59 26
tiratatp commented 3 years ago

Looking. I'll work on this tomorrow.

tiratatp commented 3 years ago

I think the problem is when you change page to the news feed.

I could see the extension is detecting this and monitor a new container.

But it does not seem to find ad elements, even though it is still using a[aria-label="Sponsored"].

@cbotsikas do you have a clue of what this could be?

tiratatp commented 3 years ago

Hi @pa28236 can you test this for me? Would the ads go away if you refresh your page?

There might be a race condition when changing page; by refreshing a page, you trigger our code to scan the page again.

cbotsikas commented 3 years ago

@tiratatp found the issue... observers were cleaned up but the dom elements were not replaced anymore, so our dataset attributes were not cleaned.

tiratatp commented 3 years ago

@cbotsikas You rock!

cbotsikas commented 3 years ago

For the record, for some reason which I don't want to search, I was not able to reproduce the problem with the console open !?

offroadpaparazzi commented 3 years ago

I can’t reproduce this at all

Hmmmm

Thank You for all you do.

-art

From: Christos Botsikas @.> Reply-To: siradar/facebook_adblock @.> Date: Wednesday, June 23, 2021 at 6:34 PM To: siradar/facebook_adblock @.> Cc: @." @.>, Comment @.> Subject: Re: [siradar/facebook_adblock] Sponsored ad got through on 1.9.3 in Chrome (#95)

For the record, for some reason which I don't want to search, I was not able to reproduce the problem with the console open !?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

tiratatp commented 3 years ago

You can update to 1.9.4 for Firefox now. But for Chrome, it is in review.

offroadpaparazzi commented 3 years ago

Thank You

On 06/24/2021 3:16 PM Tiratat P. ***@***.***> wrote:

You can update to 1.9.4 for Firefox now. But for Chrome, it is in review.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/tiratatp/facebook_adblock/issues/95#issuecomment-867889513 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AOMX636I5XYG2FL2YWSKBGLTUOACDANCNFSM43TCT6ZA .