search

facebook-atom / jest-electron-runner

custom test runner for Jest that allows tests to be run in Electron environment
MIT License
189 stars 33 forks source link

Install common globals #24

Closed Fitzpasd closed 5 years ago

Fitzpasd commented 5 years ago

Fixes #23.

Tested by applying fix locally to code that uses globals set in jest.config.js.

facebook-github-bot commented 5 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot commented 5 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

aaronabramov commented 5 years ago

thank you!

aaronabramov commented 5 years ago

published v0.2.0

Fitzpasd commented 5 years ago

Thanks for the quick publish!

Fitzpasd commented 5 years ago

@aaronabramov The published version has an out of date build. The src/Environment.js is correct, but the build/Enviornment.js wasn't built from that src.

aaronabramov commented 5 years ago

that's what you get when you don't have release automation 😞 i'll publish a new one in a minute

aaronabramov commented 5 years ago

v0.2.2 sorry about that :)

Fitzpasd commented 5 years ago

No problem, thanks for the quick turnaround from issue -> publish :). Verified everything works now.