search

facebook-atom / jest-electron-runner

custom test runner for Jest that allows tests to be run in Electron environment
MIT License
189 stars 33 forks source link

electron dependencies version are "electron": "^2.0.8", #31

Closed githoniel closed 5 years ago

githoniel commented 5 years ago

I see your package

"electron": "^2.0.8",

I'm using electron 4.0.X and this cause my project to install two version of electron.

can we just do like

"electron": *,
rajivshah3 commented 5 years ago

Maybe it should be added as a peerDependency instead?

githoniel commented 5 years ago

Yes, Maybe 

peerDependency: {
   "electron":  ">= 2.0.8"
}