search

facebook-atom / jest-electron-runner

custom test runner for Jest that allows tests to be run in Electron environment
MIT License
189 stars 33 forks source link

Add node-ipc as a dependency of @jest-runner/rpc #32

Closed elliottsj closed 5 years ago

elliottsj commented 5 years ago

In strict package managers such as pnpm or yarn pnp, node cannot resolve 'node-ipc' from @jest-runner/rpc, e.g. in RPCConnection.js:

import {IPC} from 'node-ipc';

Adding node-ipc as a direct dependency of @jest-runner/rpc fixes this.

aaronabramov commented 5 years ago

thank you!