search

facebook-atom / jest-electron-runner

custom test runner for Jest that allows tests to be run in Electron environment
MIT License
189 stars 33 forks source link

Electron 5 compatibility #42

Closed BryanPierce closed 5 years ago

BryanPierce commented 5 years ago

The nodeIntegration flag in BrowserWindow webPreferences had a default value of true in earlier versions of Electron. The default value has changed to false in Electron 5. A value of true (i.e. the presence of the Node environment) is necessary for the test runner to run as it is currently written.

facebook-github-bot commented 5 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

aaronabramov commented 5 years ago

thanks @BryanPierce!

aaronabramov commented 5 years ago

published @jest-runner/electron@2.0.1