facebook-atom / jest-electron-runner

custom test runner for Jest that allows tests to be run in Electron environment
MIT License
189 stars 33 forks source link

Incompatible with Electron 5 #43

Closed BryanPierce closed 5 years ago

BryanPierce commented 5 years ago

The nodeIntegration flag in BrowserWindow webPreferences had a default value of true in earlier versions of Electron. The default value has changed to false in Electron 5. A value of true (i.e. the presence of the Node environment) is necessary for the test runner to run as it is currently written.

I've created a PR for this (https://github.com/facebook-atom/jest-electron-runner/pull/42), but rather than jumping through the CLA hoops, it's probably easier if someone who is already legally approved to contribute to this project just adds this minor change that amounts to passing an additional flag to one constructor call.