Serial execution when running with watcher

facebook-atom / jest-electron-runner

custom test runner for Jest that allows tests to be run in Electron environment

MIT License

189 stars 33 forks source link

Serial execution when running with watcher #44

Closed hovsater closed 5 years ago

hovsater commented 5 years ago

Is there any reason why tests are run in series (see https://github.com/facebook-atom/jest-electron-runner/blob/master/packages/electron/src/TestRunner.js#L121) when running with the --watch option? It's unbearably slow and I couldn't find any references or documentation to why this was made.

aaronabramov commented 5 years ago

@KevinSjoberg i think there used to be a race condition, and having more than one worker always resulted in sketchy failures. seems like it's not the case any more. i made it use more workers here https://github.com/facebook-atom/jest-electron-runner/pull/45

hovsater commented 5 years ago

@aaronabramov thanks a lot for the explanation. Appreciate the quick fix as well. 🎉 🙌