Closed filmerjarred closed 4 years ago
Hi @BrighTide!
Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.
In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!
looks good! thank you! i'm a little worried about child processes not being killed properly, since they're detached but i'll try to test it more thoroughly
I'm not sure if this is a permanent solution (as I'm not sure what function detach:true was serving) but this enables people to easily get logs and attach a debugger to the test process which fixes #30
My rough vscode launch config below (was altered to remove a bunch of implementation specific details, so might not work if you copy exactly, but point is you use a compound launch task to 1. start the test and 2. connect to the process running the test at JEST_ELECTRON_RUNNER_DEBUG_PORT