search

facebook-atom / jest-electron-runner

custom test runner for Jest that allows tests to be run in Electron environment
MIT License
189 stars 33 forks source link

Expose garbage collector to Electron when it was exposed in Node #75

Closed kayahr closed 3 years ago

kayahr commented 3 years ago

Thanks to the new WeakRef feature it is possible to test for memory leaks when exposing the garbage collector to Node. With this pull request the garbage collector is also exposed to Electron when it was exposed to Node so the same tests which works with Node runner can also work with electron runner.

facebook-github-bot commented 3 years ago

Hi @kayahr!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot commented 3 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

kayahr commented 3 years ago

Any feedback on this pull request? It is a very small change, it doesn't change any behavior except exposing the garbage collector to Electron and even this is only done when the user already exposed the garbage collector to Node. So for the standard usage this small change doesn't do anything. And for those who expose the garbage collector to Node this change is very useful for writing unit tests running in Electron which can check for memory leaks.