search

facebook-csharp-sdk / simple-json

JSON library for .NET 2.0+/SL4+/WP7/WindowsStore with optional support for dynamic and DataContract
MIT License
380 stars 143 forks source link

Change SimpleJson to be a static class #25

Closed haacked closed 11 years ago

haacked commented 11 years ago

The class has no instance members, thus it should be a static class. SimpleJson's README lists .NET 2.0 as the minimal supported version. Static classes are supported in C# 2.

Also, when I add the library to my project, I get a lot of FxCop violations. I'll send a PR with more suppressions and/or fixes.

Any plans to drop .NET 2.0 support ever?

prabirshrestha commented 11 years ago

Any reason why you would want to drop .NET 2.0?

We also need to support unity3d, which is based on mono and .net 2.0.

haacked commented 11 years ago

I was just curious. The less you support, the more language features you get to use to clean things up. :)

haacked commented 11 years ago

For example, I can't use Func because that was introduced in .NET 3.5. That could clean up a lot of gnarly code. :)

haacked commented 11 years ago

Forget this one. Look at #26 which includes this commit and more. :)