search

facebook-csharp-sdk / simple-json

JSON library for .NET 2.0+/SL4+/WP7/WindowsStore with optional support for dynamic and DataContract
MIT License
380 stars 143 forks source link

Codeanalysis fixes #26

Closed haacked closed 11 years ago

haacked commented 11 years ago

This includes the commit from my other PR. You can ignore that one if you accept this one.

In this one, I fixed a few Code Analysis performance rules by removing unnecessary casts. I tried to do the minimal amount of work to satisfy the rules. I think there's definitely some more refactoring worth doing later. :)

Also fixed a few design rules. Minor stuff. All tests continue to pass.

haacked commented 11 years ago

Ah, ok. Maybe you should make the copy of ReflectionUtils part of the build. :)

haacked commented 11 years ago

Actually, it should probably be a submodule. Are you familiar with git submodules?

haacked commented 11 years ago

OR (sorry for the spam) make it a nuget package that deploys a .cs file and make Simple.Json depend on it. At the end of the day, it's the same result other than it's 2 files being added to and compiled into a project rather than one.

haacked commented 11 years ago

Ok, I made all the changes you requested. I did it in a new commit to make it easy to review. If you'd prefer me to rebase code review changes into the original commits on my branch before you merge, let me know.

prabirshrestha commented 11 years ago

needs rebase

haacked commented 11 years ago

I'm going to close this one and put it all in my other PR. Fine with you?

prabirshrestha commented 11 years ago

i'm fine with it