search

facebook-csharp-sdk / simple-json

JSON library for .NET 2.0+/SL4+/WP7/WindowsStore with optional support for dynamic and DataContract
MIT License
380 stars 143 forks source link

Add support for .NET 4.5 readonly collections #44

Closed haacked closed 10 years ago

haacked commented 10 years ago

This also adds a new compiler constant: SIMPLE_JSON_READONLY_COLLECTIONS for platforms that support IReadOnlyList<> and IReadOnlyCollection<>

/cc @shiftkey

prabirshrestha commented 10 years ago

jake build fails.

SimpleJson.cs(1653,52): error CS0246: The type or namespace name 'IReadOnlyCollection' could not be found (are you missing a using directive or an assembly reference?) [z:\projects\github\simple-json\src\SimpleJson\SimpleJson-WP7.csproj] SimpleJson.cs(1654,52): error CS0246: The type or namespace name 'IReadOnlyList ' could not be found (are you missing a using directive or an assembly referenc e?) [z:\projects\github\simple-json\src\SimpleJson\SimpleJson-WP7.csproj]
haacked commented 10 years ago

Weird. THose built on my machine. I force pushed an update that just does the change to the .NET 4.5 projects.

prabirshrestha commented 10 years ago

thanks

prabirshrestha commented 10 years ago

v0.32.0 with readonly collection support has been published to nuget. I also added a short doc in readme about the new SIMPLE_JSON_READONLY_COLLECTIONS flag as well as in SimpleJson.cs file.

haacked commented 10 years ago

Thanks! :thumbsup: