search

facebook-csharp-sdk / simple-json

JSON library for .NET 2.0+/SL4+/WP7/WindowsStore with optional support for dynamic and DataContract
MIT License
382 stars 143 forks source link

Optionally support DataContract in Mono/Unity #61

Open Esam-Bustaty opened 10 years ago

Esam-Bustaty commented 10 years ago

Mono doesn't implement the attributes DataContract/DataMember/IgnoreDataMember, so to be able to use them in Unity/Mono i added a define to implement them in SimpleJson namespace, just define ALTERNATE_DATACONTRACT to enable the alternate definition.

Esam-Bustaty commented 10 years ago

Did the rename, it's now SIMPLE_JSON_REDEFINE_DATACONTRACT_ATTRIBUTES.

Esam-Bustaty commented 10 years ago

so, is this waiting for something from me? i want to make other pull requests, but as I'm new to github, I wanted to do them one by one, as each one is a separate feature, so if there is something that I can do to accelerate this, I'm happy to do, otherwise, how can I make other pull requests? maybe port again? how these things are usually done?

prabirshrestha commented 10 years ago

will try merging and releasing this later tonight.

The rule is not to update your master with your patches. This allows you to work on multiple features at the same time. Here is a good workflow from Nancy. https://github.com/NancyFx/Nancy/wiki/Git-Workflow