search

facebook / Ax

Adaptive Experimentation Platform
https://ax.dev
MIT License
2.36k stars 307 forks source link

MOO Tutorial potentially incorrect model #2452

Closed basarkutukcu closed 5 months ago

basarkutukcu commented 5 months ago

In MOO Tutorial notebook (https://ax.dev/tutorials/multiobjective_optimization.html), "get_MOO_EHVI" is imported as below but never used.

# Factory methods for creating multi-objective optimization modesl.
from ax.modelbridge.factory import get_MOO_EHVI, get_MOO_PAREGO

Instead Models.BOTORCH_MODULAR is used. Is this a mistake or intentional?

  ehvi_model = Models.BOTORCH_MODULAR(
      experiment=ehvi_experiment,
      data=ehvi_data,
  )
bernardbeckerman commented 5 months ago

Thanks for pointing this out! I'll put up a change to rectify this : )

basarkutukcu commented 5 months ago

I actually commented on the PR but I think it's hard to see the comment there. I am copying the comment below. @bernardbeckerman What do you think?

Is this the correct fix for the problem? I was expecting a change to use get_MOO_EHVI instead of Models.BOTORCH_MODULAR as following.

      ehvi_model = get_MOO_EHVI(
          experiment=ehvi_experiment,
          data=ehvi_data,
      )
bernardbeckerman commented 4 months ago

This new BOTORCH_MODULAR model type replaced the legacy get_MOO_EHVI in https://github.com/facebook/Ax/pull/1982 and should be used in its place going forward. Please let me know if you have further questions!