search

facebook / Ax

Adaptive Experimentation Platform
https://ax.dev
MIT License
2.35k stars 303 forks source link

Adds test that all constructors and purposes are tested and that they all share the same signature #2764

Closed mgarrard closed 6 days ago

mgarrard commented 2 weeks ago

Summary: This is a requested follow up by Liz/Sait/Daniel to (1) ensure all constructor methods share the same signature and (2) ensure that they are all tested.

For two, this still relies on best effort to ensure that when you add a new constructor you actually add the relevant tests, but it will ensure that the new constructor has the correct signature.

These input constructors are more simple than those used in the modeling layer so i do believe they should be less error prone generally

Follow up diffs:

Differential Revision: D62553827

facebook-github-bot commented 2 weeks ago

This pull request was exported from Phabricator. Differential Revision: D62553827

facebook-github-bot commented 6 days ago

This pull request was exported from Phabricator. Differential Revision: D62553827

codecov-commenter commented 6 days ago

Codecov Report

Attention: Patch coverage is 99.37107% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.68%. Comparing base (d738685) to head (e95327f).

Files with missing lines Patch % Lines
.../modelbridge/generation_node_input_constructors.py 96.96% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2764 +/- ## ======================================== Coverage 95.67% 95.68% ======================================== Files 486 488 +2 Lines 47718 47868 +150 ======================================== + Hits 45655 45802 +147 - Misses 2063 2066 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

facebook-github-bot commented 6 days ago

This pull request has been merged in facebook/Ax@549adf0cc9de77b604049632fa7831bcefcb43f3.