facebook / Ax

Adaptive Experimentation Platform
https://ax.dev
MIT License
2.38k stars 311 forks source link

In 'best_point' don't require GeneratorRun to have best_arm_predictions to predict from model #2767

Closed esantorella closed 2 months ago

esantorella commented 2 months ago

Summary: Context:

get_best_parameters_from_model_predictions_with_trial_index will only predict from a model if there are best_arm_predictions on the GeneratorRun. This doesn't make sense, since it's about to construct and fit a new model and use it to generate predicts. Any existing best_arm_predictions are not used.

This PR:

Reviewed By: mpolson64

Differential Revision: D62594017

facebook-github-bot commented 2 months ago

This pull request was exported from Phabricator. Differential Revision: D62594017

facebook-github-bot commented 2 months ago

This pull request has been merged in facebook/Ax@2fc80f11ca7df8b192eaca0590e0902a5196b8e6.