search

facebook / Ax

Adaptive Experimentation Platform
https://ax.dev
MIT License
2.38k stars 311 forks source link

Remove hypothesis dependency #2774

Closed esantorella closed 1 month ago

esantorella commented 1 month ago

Summary: Context: Hypothesis is not commonly used in Ax and is not part of the UNITTEST_MINIMAL_REQUIRES dependencies (although it is part of UNITTEST_REQUIRES). It is used in only one benchmarking test. Removing it will make it easier to build an environment that can run benchmark tests. We could have a broader discussion about removing it from Ax entirely.

This diff: Changes a unit test to not use hypothesis

Reviewed By: saitcakmak

Differential Revision: D63150787

facebook-github-bot commented 1 month ago

This pull request was exported from Phabricator. Differential Revision: D63150787

facebook-github-bot commented 1 month ago

This pull request was exported from Phabricator. Differential Revision: D63150787

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.67%. Comparing base (a0fe4d3) to head (3c72cc4).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2774 +/- ## ======================================= Coverage 95.67% 95.67% ======================================= Files 486 486 Lines 47712 47713 +1 ======================================= + Hits 45649 45650 +1 Misses 2063 2063 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

facebook-github-bot commented 1 month ago

This pull request has been merged in facebook/Ax@2e7291e474d3175cfd244b601d093d0b3279ac17.