search

facebook / Ax

Adaptive Experimentation Platform
https://ax.dev
MIT License
2.35k stars 303 forks source link

Have scheduler give clearer error message when it has no metrics #2775

Closed esantorella closed 6 days ago

esantorella commented 1 week ago

Summary: Scheduler used to complain about metrics not implementing fetching logic either when there are metrics but they don't implement fetching logic or when there are no metrics. Now the latter situation gives an error that the metrics must not be None.

Reviewed By: Balandat

Differential Revision: D63151740

facebook-github-bot commented 1 week ago

This pull request was exported from Phabricator. Differential Revision: D63151740

codecov-commenter commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.67%. Comparing base (2e7291e) to head (1eab534).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2775 +/- ## ======================================= Coverage 95.67% 95.67% ======================================= Files 486 486 Lines 47713 47718 +5 ======================================= + Hits 45650 45655 +5 Misses 2063 2063 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

facebook-github-bot commented 6 days ago

This pull request has been merged in facebook/Ax@34ad4d0535f7d25313dc490512b68e65f82b89e2.