Closed esantorella closed 1 month ago
This pull request was exported from Phabricator. Differential Revision: D63327381
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 95.68%. Comparing base (
a144287
) to head (e1b7f3b
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This pull request was exported from Phabricator. Differential Revision: D63327381
This pull request was exported from Phabricator. Differential Revision: D63327381
This pull request was exported from Phabricator. Differential Revision: D63327381
This pull request was exported from Phabricator. Differential Revision: D63327381
This pull request was exported from Phabricator. Differential Revision: D63327381
This pull request has been merged in facebook/Ax@6899783ddbbcd92f5114c908b56959e1dd83cbc7.
Summary: Sometimes benchmarking code creates Arms from parameters just so they can be passed to a function that expects an Arm but only uses its parameters. This is silly. It's better to just have the function expect parameters.
Also updated some method signatures to use
Mapping
to indicate that they do not mutate the parameterization, which unfortunately creates the need for Pyre-fixmes if they are passed to a function or class such asArm
that does not annotate its arguments as immutable.Differential Revision: D63327381