facebook / Ax

Adaptive Experimentation Platform
https://ax.dev
MIT License
2.35k stars 303 forks source link

Indicate constraint violations in predicted effects plot #2783

Open danielcohenlive opened 5 days ago

danielcohenlive commented 5 days ago

Summary: Points that may violate any constraint should be marked with an x instead of a circle.

On hover it should indicate the % chance that the arm violates the given constraint.

Differential Revision: D63290929

facebook-github-bot commented 5 days ago

This pull request was exported from Phabricator. Differential Revision: D63290929

codecov-commenter commented 5 days ago

Codecov Report

Attention: Patch coverage is 98.83268% with 3 lines in your changes missing coverage. Please review.

Project coverage is 95.70%. Comparing base (8ba8ce3) to head (8e20788).

Files with missing lines Patch % Lines
ax/analysis/plotly/predicted_effects.py 97.41% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2783 +/- ## ========================================== + Coverage 95.68% 95.70% +0.01% ========================================== Files 488 490 +2 Lines 47843 48098 +255 ========================================== + Hits 45779 46031 +252 - Misses 2064 2067 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

facebook-github-bot commented 5 days ago

This pull request was exported from Phabricator. Differential Revision: D63290929

facebook-github-bot commented 2 days ago

This pull request was exported from Phabricator. Differential Revision: D63290929

facebook-github-bot commented 2 days ago

This pull request was exported from Phabricator. Differential Revision: D63290929

facebook-github-bot commented 2 days ago

This pull request was exported from Phabricator. Differential Revision: D63290929

facebook-github-bot commented 2 days ago

This pull request was exported from Phabricator. Differential Revision: D63290929

facebook-github-bot commented 2 days ago

This pull request was exported from Phabricator. Differential Revision: D63290929

facebook-github-bot commented 2 days ago

This pull request was exported from Phabricator. Differential Revision: D63290929

facebook-github-bot commented 2 days ago

This pull request was exported from Phabricator. Differential Revision: D63290929