search

facebook / Ax

Adaptive Experimentation Platform
https://ax.dev
MIT License
2.35k stars 303 forks source link

Don't require n in the signature of gen mfm and multiple nodes methods #2787

Closed danielcohenlive closed 2 days ago

danielcohenlive commented 4 days ago

Summary: This is so in the future n can be logically determined inside GS.

Reviewed By: mgarrard

Differential Revision: D63343207

facebook-github-bot commented 4 days ago

This pull request was exported from Phabricator. Differential Revision: D63343207

codecov-commenter commented 4 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.68%. Comparing base (a144287) to head (cd5359b).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2787 +/- ## ======================================= Coverage 95.68% 95.68% ======================================= Files 488 488 Lines 47985 47990 +5 ======================================= + Hits 45915 45920 +5 Misses 2070 2070 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

facebook-github-bot commented 3 days ago

This pull request was exported from Phabricator. Differential Revision: D63343207

facebook-github-bot commented 3 days ago

This pull request was exported from Phabricator. Differential Revision: D63343207

facebook-github-bot commented 3 days ago

This pull request was exported from Phabricator. Differential Revision: D63343207

facebook-github-bot commented 2 days ago

This pull request was exported from Phabricator. Differential Revision: D63343207

facebook-github-bot commented 2 days ago

This pull request was exported from Phabricator. Differential Revision: D63343207

facebook-github-bot commented 2 days ago

This pull request has been merged in facebook/Ax@134e9edde90d3334134b55e6f871ea6143aa4448.