search

facebook / Ax

Adaptive Experimentation Platform
https://ax.dev
MIT License
2.35k stars 303 forks source link

Fix sqa storage issue for input_constructors #2791

Closed mgarrard closed 7 hours ago

mgarrard commented 3 days ago

Summary: I recently added storage for input constructors, and our json tests pass for this because json is able to eloquently handle the enum of inputconstructorpurpose since the enum value is a string, however, it looks like sqa storage is not able to do this.

Differential Revision: D63442156

facebook-github-bot commented 3 days ago

This pull request was exported from Phabricator. Differential Revision: D63442156

facebook-github-bot commented 3 days ago

This pull request was exported from Phabricator. Differential Revision: D63442156

facebook-github-bot commented 3 days ago

This pull request was exported from Phabricator. Differential Revision: D63442156

facebook-github-bot commented 3 days ago

This pull request was exported from Phabricator. Differential Revision: D63442156

codecov-commenter commented 3 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.72%. Comparing base (0d05f21) to head (2e9e360).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2791 +/- ## ======================================= Coverage 95.72% 95.72% ======================================= Files 490 490 Lines 48413 48437 +24 ======================================= + Hits 46342 46366 +24 Misses 2071 2071 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

facebook-github-bot commented 3 days ago

This pull request was exported from Phabricator. Differential Revision: D63442156

facebook-github-bot commented 2 days ago

This pull request was exported from Phabricator. Differential Revision: D63442156

facebook-github-bot commented 2 days ago

This pull request was exported from Phabricator. Differential Revision: D63442156

facebook-github-bot commented 2 days ago

This pull request was exported from Phabricator. Differential Revision: D63442156

facebook-github-bot commented 11 hours ago

This pull request was exported from Phabricator. Differential Revision: D63442156

facebook-github-bot commented 10 hours ago

This pull request was exported from Phabricator. Differential Revision: D63442156

facebook-github-bot commented 7 hours ago

This pull request has been merged in facebook/Ax@e09033c5d834eec5ae4ea70d01bae0a93c2efce6.