search

facebook / Ax

Adaptive Experimentation Platform
https://ax.dev
MIT License
2.38k stars 312 forks source link

Add generation blocking criterion to Sobol -> MBM criterion #3018

Open mgarrard opened 2 weeks ago

mgarrard commented 2 weeks ago

Summary: By adding this criterion at the sobol to mbm criterion, we push the data requirement check into the GenerationStrategy layer, which makes the most sense as having data is required for the modeling layer to succeed.

Differential Revision: D65434205

facebook-github-bot commented 2 weeks ago

This pull request was exported from Phabricator. Differential Revision: D65434205

codecov-commenter commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.60%. Comparing base (93c236e) to head (37ed335).

Files with missing lines Patch % Lines
ax/modelbridge/transition_criterion.py 66.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3018 +/- ## ========================================== - Coverage 95.60% 95.60% -0.01% ========================================== Files 483 483 Lines 49012 49015 +3 ========================================== + Hits 46859 46861 +2 - Misses 2153 2154 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

facebook-github-bot commented 2 weeks ago

This pull request was exported from Phabricator. Differential Revision: D65434205