search

facebook / Ax

Adaptive Experimentation Platform
https://ax.dev
MIT License
2.38k stars 312 forks source link

Set Scheduler logging level appropriately #3028

Closed paschai closed 2 weeks ago

paschai commented 2 weeks ago

Summary: Currently, setting the logging_level in SchedulerOptions actually sets the root stream handler's level - this shouldn't be the case, as the correct intention is to set the logging level of the Scheduler logger.

This diff is to correct the level handling for the Scheduler logger.

Differential Revision: D65555729

facebook-github-bot commented 2 weeks ago

This pull request was exported from Phabricator. Differential Revision: D65555729

codecov-commenter commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.64%. Comparing base (22bd1b2) to head (819ec1c).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3028 +/- ## ========================================== - Coverage 95.64% 95.64% -0.01% ========================================== Files 483 483 Lines 49048 49069 +21 ========================================== + Hits 46910 46930 +20 - Misses 2138 2139 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

facebook-github-bot commented 2 weeks ago

This pull request was exported from Phabricator. Differential Revision: D65555729

facebook-github-bot commented 2 weeks ago

This pull request was exported from Phabricator. Differential Revision: D65555729

facebook-github-bot commented 2 weeks ago

This pull request was exported from Phabricator. Differential Revision: D65555729

facebook-github-bot commented 2 weeks ago

This pull request was exported from Phabricator. Differential Revision: D65555729

facebook-github-bot commented 2 weeks ago

This pull request was exported from Phabricator. Differential Revision: D65555729

facebook-github-bot commented 2 weeks ago

This pull request was exported from Phabricator. Differential Revision: D65555729

facebook-github-bot commented 2 weeks ago

This pull request has been merged in facebook/Ax@8a0fbefc3a0b44c7ee70e7418fb2684973ee6fef.