search

facebook / Ax

Adaptive Experimentation Platform
https://ax.dev
MIT License
2.38k stars 312 forks source link

Move estimate...savings to respective Strategy base classes #3056

Open paschai opened 1 week ago

paschai commented 1 week ago

Differential Revision: D65831213

facebook-github-bot commented 1 week ago

This pull request was exported from Phabricator. Differential Revision: D65831213

codecov-commenter commented 1 week ago

Codecov Report

Attention: Patch coverage is 81.25000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 95.67%. Comparing base (6e93124) to head (2bfcb7a).

Files with missing lines Patch % Lines
ax/early_stopping/strategies/base.py 66.66% 4 Missing :warning:
ax/early_stopping/tests/test_strategies.py 85.71% 1 Missing :warning:
ax/global_stopping/strategies/base.py 80.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3056 +/- ## ========================================== - Coverage 95.68% 95.67% -0.01% ========================================== Files 485 485 Lines 49297 49312 +15 ========================================== + Hits 47169 47180 +11 - Misses 2128 2132 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.