search

facebook / Ax

Adaptive Experimentation Platform
https://ax.dev
MIT License
2.38k stars 312 forks source link

Remove redundant MultiObjectiveOptimizationConfig.metrics definition #3062

Closed saitcakmak closed 1 week ago

saitcakmak commented 1 week ago

Summary: The base property can use all_constraints, which makes the redefined property redundant.

Differential Revision: D65888209

facebook-github-bot commented 1 week ago

This pull request was exported from Phabricator. Differential Revision: D65888209

codecov-commenter commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.68%. Comparing base (df94a3d) to head (abae01d). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3062 +/- ## ========================================== - Coverage 95.68% 95.68% -0.01% ========================================== Files 485 485 Lines 49295 49289 -6 ========================================== - Hits 47168 47160 -8 - Misses 2127 2129 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

facebook-github-bot commented 1 week ago

This pull request has been merged in facebook/Ax@2317f8c45db1767b21fcaf3acb5ccdcc6c08866f.