search

facebook / Ax

Adaptive Experimentation Platform
https://ax.dev
MIT License
2.38k stars 312 forks source link

Remove `outcome_index` from `BenchmarkMetric` #3063

Closed esantorella closed 1 week ago

esantorella commented 1 week ago

Summary: It is never used or needed, because outcome_names are always present in BenchmarkMetadata.

Differential Revision: D65900539

facebook-github-bot commented 1 week ago

This pull request was exported from Phabricator. Differential Revision: D65900539

codecov-commenter commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.68%. Comparing base (2317f8c) to head (fc08b75).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3063 +/- ## ========================================== - Coverage 95.68% 95.68% -0.01% ========================================== Files 486 486 Lines 49304 49300 -4 ========================================== - Hits 47178 47172 -6 - Misses 2126 2128 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

facebook-github-bot commented 1 week ago

This pull request has been merged in facebook/Ax@cbf322b5e2b0a8a3afe6286b372c3b9bf6f2f81f.