search

facebook / Ax

Adaptive Experimentation Platform
https://ax.dev
MIT License
2.38k stars 312 forks source link

Make sure we're instantiating the same metric class we deserialized kwargs for #3064

Closed danielcohenlive closed 1 week ago

danielcohenlive commented 1 week ago

Summary: This fixes a bug in core AxClient where if there was a special metric class it would be ignored in deserialization of metric definitions, and if that metric class had special kwargs it would error.

Reviewed By: andycylmeta

Differential Revision: D65912854

facebook-github-bot commented 1 week ago

This pull request was exported from Phabricator. Differential Revision: D65912854

codecov-commenter commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.68%. Comparing base (cbf322b) to head (a641afd).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3064 +/- ## ======================================= Coverage 95.68% 95.68% ======================================= Files 486 486 Lines 49300 49306 +6 ======================================= + Hits 47172 47180 +8 + Misses 2128 2126 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

facebook-github-bot commented 1 week ago

This pull request has been merged in facebook/Ax@c926f03fcb03d9954d1985b409b099cb895c0ee0.