Ax benchmarking: Separate defining outcome names from auto-creating an OptimizationConfig

esantorella commented 1 week ago

Summary: Context: get_soo_config_and_outcome_names and get_moo_opt_config_and_outcome_names both create an OptimizationConfig, creating metric names such as "objective_0" and "constraint_slack_0". By separating out the logic for constructing objective and constraint names, this can be used more widely for problems that use different names for metrics.

This PR:

Changes get_soo_config_and_outcome_names to get_soo_opt_config, and makes it require outcome names rather than returning them.
Does the same for get_moo_opt_config_and_outcome_names
Updates several problem definitions to use the new functions get_soo_opt_config and get_moo_opt_config, to increase code reuse.

Reviewed By: saitcakmak

Differential Revision: D65890910

facebook-github-bot commented 1 week ago

This pull request was exported from Phabricator. Differential Revision: D65890910

codecov-commenter commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.68%. Comparing base (e20c48e) to head (27568e0).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #3065 +/- ## ========================================== - Coverage 95.68% 95.68% -0.01% ========================================== Files 486 486 Lines 49341 49357 +16 ========================================== + Hits 47211 47225 +14 - Misses 2130 2132 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

facebook-github-bot commented 1 week ago

This pull request has been merged in facebook/Ax@709fe44adf675c10bf3424bb2b12430fdbb0aa21.

facebook / Ax

Ax benchmarking: Separate defining outcome names from auto-creating an OptimizationConfig #3065

Codecov Report