search

facebook / Ax

Adaptive Experimentation Platform
https://ax.dev
MIT License
2.38k stars 312 forks source link

Remove unused function from benchmark_stubs #3066

Closed esantorella closed 1 week ago

esantorella commented 1 week ago

Summary: get_sobol_gpei_benchmark_method is used only for testing JSON serialization; instead use a method that's defined elsewhere

Reviewed By: saitcakmak

Differential Revision: D65908525

facebook-github-bot commented 1 week ago

This pull request was exported from Phabricator. Differential Revision: D65908525

codecov-commenter commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.68%. Comparing base (e20c48e) to head (7ade9c6).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3066 +/- ## ========================================== - Coverage 95.68% 95.68% -0.01% ========================================== Files 486 486 Lines 49341 49351 +10 ========================================== + Hits 47211 47220 +9 - Misses 2130 2131 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

facebook-github-bot commented 1 week ago

This pull request has been merged in facebook/Ax@73ba7a6bc10715b145fc5dbc62994dc579031398.