Closed esantorella closed 1 week ago
This pull request was exported from Phabricator. Differential Revision: D65712886
This pull request was exported from Phabricator. Differential Revision: D65712886
Attention: Patch coverage is 75.00000%
with 3 lines
in your changes missing coverage. Please review.
Project coverage is 95.67%. Comparing base (
e20c48e
) to head (f43738f
).
Files with missing lines | Patch % | Lines |
---|---|---|
ax/benchmark/problems/runtime_funcs.py | 40.00% | 3 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This pull request has been merged in facebook/Ax@9142af8297e70266e389b20a7074e2cfbd5d35e5.
Summary: Adds a benchmark that runs the Ackley4 problem with
Other changes (some cleanup from enabling asynchronicity and minor fixes):
get_sobol_mbm_generation_strategy
fromget_sobol_botorch_modular_acquisition
(which should really be calledget_sobol_botorch_modular_method
).get_sobol_botorch_modular_acquisition
is now unneeded, asget_sobol_botorch_modular_acquisition(generation_strategy=get_sobol_mbm_generation_strategy(), **kwargs)
is equivalent toBenchmarkMethod(generation_strategy=get_sobol_mbm_generation_strategy(), **kwargs)
.Reviewed By: Balandat
Differential Revision: D65712886