facebook / Ax

Adaptive Experimentation Platform
https://ax.dev
MIT License
2.38k stars 312 forks source link

Allow pending trials to complete when failure rate is exceeded #3070

Closed SebastianAment closed 1 day ago

SebastianAment commented 1 week ago

Summary: This commit allows any pending trials to be completed when the maximum permissible failure rate is exceeded. This is achieved adding a private Boolean attribute _failure_rate_has_been_exceeded, which causes _get_max_pending_trials to return returning 0 when it is true, leading the scheduler to stop adding new trials.

Differential Revision: D65943818

facebook-github-bot commented 1 week ago

This pull request was exported from Phabricator. Differential Revision: D65943818

codecov-commenter commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.69%. Comparing base (7b671dc) to head (31be013).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3070 +/- ## ========================================== - Coverage 95.69% 95.69% -0.01% ========================================== Files 488 488 Lines 49510 49526 +16 ========================================== + Hits 47381 47396 +15 - Misses 2129 2130 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

facebook-github-bot commented 6 days ago

This pull request was exported from Phabricator. Differential Revision: D65943818

facebook-github-bot commented 2 days ago

This pull request was exported from Phabricator. Differential Revision: D65943818

facebook-github-bot commented 2 days ago

This pull request was exported from Phabricator. Differential Revision: D65943818

facebook-github-bot commented 1 day ago

This pull request has been merged in facebook/Ax@fa4c3b5b4f7601d3bae9a3686f47d8f6c04b576d.