Closed SebastianAment closed 1 day ago
This pull request was exported from Phabricator. Differential Revision: D65943818
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 95.69%. Comparing base (
7b671dc
) to head (31be013
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚨 Try these New Features:
This pull request was exported from Phabricator. Differential Revision: D65943818
This pull request was exported from Phabricator. Differential Revision: D65943818
This pull request was exported from Phabricator. Differential Revision: D65943818
This pull request has been merged in facebook/Ax@fa4c3b5b4f7601d3bae9a3686f47d8f6c04b576d.
Summary: This commit allows any pending trials to be completed when the maximum permissible failure rate is exceeded. This is achieved adding a private Boolean attribute
_failure_rate_has_been_exceeded
, which causes_get_max_pending_trials
to return returning0
when it is true, leading the scheduler to stop adding new trials.Differential Revision: D65943818