Closed esantorella closed 2 days ago
This pull request was exported from Phabricator. Differential Revision: D66010090
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 95.72%. Comparing base (
7b671dc
) to head (c519aab
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚨 Try these New Features:
This pull request was exported from Phabricator. Differential Revision: D66010090
This pull request was exported from Phabricator. Differential Revision: D66010090
This pull request has been merged in facebook/Ax@e17f075cd940ff0827346d162e4e3d97fe9d179b.
Summary: This PR:
early_stopping_strategy
attribute toBenchmarkMethod
. It is then passed toSchedulerOptions
, and gets used by Scheduler (as in the benchmarking code never needs to reference or call theearly_stopping_strategy
)seconds_between_polls
on the ESS to 0, to matchseconds_between_polls
inSchedulerOptions
. If this were not done, both would be set to theseconds_between_polls
on the ESS, which by default is 300. Also, warn if this has been done.Unrelated change:
ThresholdEarlyStoppingStrategy
to say it is checking for "worse" rather than "greater" values, since it does seem to account for whether the metric is to be minimized or maximized.Differential Revision: D66010090