Remove unused `_init_state` and `reset()` from `BackendSimulator`

facebook / Ax

Adaptive Experimentation Platform

https://ax.dev

MIT License

2.38k stars 312 forks source link

Remove unused `_init_state` and `reset()` from `BackendSimulator` #3075

Closed esantorella closed 3 days ago

esantorella commented 3 days ago

Summary: Context: The BackendSimulator can be reset to its initial state. This functionality is not used. I would like to be able to serialize and deserialize BackendSimulators in order to permit analysis of past simulations. The presence of _init_state makes this much harder, since there are then two states that need to be considered, the initial state and the current state.

This PR:

Removes the attribute _init_state and the method reset from BackendSimulator

Differential Revision: D66100116

facebook-github-bot commented 3 days ago

This pull request was exported from Phabricator. Differential Revision: D66100116

codecov-commenter commented 3 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.69%. Comparing base (0cab5d2) to head (a08d896).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #3075 +/- ## ========================================== - Coverage 95.70% 95.69% -0.01% ========================================== Files 487 487 Lines 49525 49504 -21 ========================================== - Hits 47396 47375 -21 Misses 2129 2129 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests
JS Bundle Analysis - Avoid shipping oversized bundles

facebook-github-bot commented 3 days ago

This pull request has been merged in facebook/Ax@7526bcdcd46308b580e0f9300fa6ea958d1aeaaa.