Give `BackendSimulator` an `options` attribute

facebook / Ax

Adaptive Experimentation Platform

https://ax.dev

MIT License

2.38k stars 312 forks source link

Give `BackendSimulator` an `options` attribute #3076

Closed esantorella closed 3 days ago

esantorella commented 3 days ago

Summary: Currently, a BackendSimulator is initialized by passing BackendSimulatorOptions. All of the attributes of those options, such as max_parallelism, are then written to BackendSimulator itself. This PR gives BackendSimulator an options: BackendSimulatorOptions attribute, and makes attributes of options into properties of the simulator. This will make serialization easier, by having the initialization arguments of BackendSimulator more similar to its attributes.

Differential Revision: D66102162

facebook-github-bot commented 3 days ago

This pull request was exported from Phabricator. Differential Revision: D66102162

codecov-commenter commented 3 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.69%. Comparing base (0cab5d2) to head (90ecc89).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #3076 +/- ## ========================================== - Coverage 95.70% 95.69% -0.01% ========================================== Files 487 487 Lines 49525 49509 -16 ========================================== - Hits 47396 47378 -18 - Misses 2129 2131 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests
JS Bundle Analysis - Avoid shipping oversized bundles

facebook-github-bot commented 3 days ago

This pull request has been merged in facebook/Ax@17bdef7f21c19bafdea6428e7d298aa686d5dcef.