facebook / Ax

Adaptive Experimentation Platform
https://ax.dev
MIT License
2.38k stars 312 forks source link

Prepare for "Fix type-safety of `torch.nn.Module` instances": fbcode/a* #3088

Closed ezyang closed 1 day ago

ezyang commented 1 day ago

Summary: In D52890934 we are tightening the type signature on attributes on nn Module. To do this, we need to first apply Pyre fixme to all sites that were relying on the old Any. This diff shards out all changes to files that begin with a.

Differential Revision: D66233582

facebook-github-bot commented 1 day ago

This pull request was exported from Phabricator. Differential Revision: D66233582

codecov-commenter commented 1 day ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.74%. Comparing base (1f9f742) to head (86c05e2).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3088 +/- ## ======================================= Coverage 95.74% 95.74% ======================================= Files 488 488 Lines 49769 49769 ======================================= Hits 47653 47653 Misses 2116 2116 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

facebook-github-bot commented 1 day ago

This pull request was exported from Phabricator. Differential Revision: D66233582

facebook-github-bot commented 1 day ago

This pull request was exported from Phabricator. Differential Revision: D66233582

facebook-github-bot commented 1 day ago

This pull request was exported from Phabricator. Differential Revision: D66233582

facebook-github-bot commented 1 day ago

This pull request has been merged in facebook/Ax@1efbcbdc50fa876ff83f533ea8e7b7afec82e0ca.