facebook / Ax

Adaptive Experimentation Platform
https://ax.dev
MIT License
2.38k stars 312 forks source link

Reap completion_criterion method #3092

Open paschai opened 1 day ago

paschai commented 1 day ago

Summary: As titled - this diff moves the logic from completion_criterion to should_consider_optimization_complete

Cleanup tasks can be found in https://fburl.com/gdoc/xiet9m0v

Differential Revision: D66245238

facebook-github-bot commented 1 day ago

This pull request was exported from Phabricator. Differential Revision: D66245238

codecov-commenter commented 1 day ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.75%. Comparing base (0f17048) to head (5fe40cc).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3092 +/- ## ======================================= Coverage 95.74% 95.75% ======================================= Files 488 488 Lines 49749 49747 -2 ======================================= - Hits 47634 47633 -1 + Misses 2115 2114 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features: