facebook / Ax

Adaptive Experimentation Platform
https://ax.dev
MIT License
2.38k stars 312 forks source link

SlicePlot (for use in InteractionPlot) #3094

Closed mpolson64 closed 14 hours ago

mpolson64 commented 1 day ago

Summary: Reimplement the Slice plot using the new Analysis setup. This is not necessarily urgent in and of itself, but it will be used in the modernized interaction plot (to promote code reuse).

Differential Revision: D65234219

facebook-github-bot commented 1 day ago

This pull request was exported from Phabricator. Differential Revision: D65234219

codecov-commenter commented 1 day ago

Codecov Report

Attention: Patch coverage is 87.25490% with 13 lines in your changes missing coverage. Please review.

Project coverage is 95.73%. Comparing base (1efbcbd) to head (7dd8cb0).

Files with missing lines Patch % Lines
ax/analysis/plotly/surface/utils.py 47.61% 11 Missing :warning:
ax/analysis/plotly/surface/slice.py 95.91% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3094 +/- ## ========================================== - Coverage 95.74% 95.73% -0.02% ========================================== Files 488 492 +4 Lines 49769 49871 +102 ========================================== + Hits 47653 47742 +89 - Misses 2116 2129 +13 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

facebook-github-bot commented 1 day ago

This pull request was exported from Phabricator. Differential Revision: D65234219

facebook-github-bot commented 1 day ago

This pull request was exported from Phabricator. Differential Revision: D65234219

facebook-github-bot commented 14 hours ago

This pull request has been merged in facebook/Ax@4a8804eb05347d079f74e9d4c8a9b4b365abe2a4.