ContourPlot (for use in InteractionPlot)

[mpolson64]

Summary: Reimplement the Contour plot using the new Analysis setup. This is not necessarily urgent in and of itself, but it will be used in the modernized interaction plot (to promote code reuse).

Note that we have changed a number of things here which make the contour much better for the interaction analysis, and debatably make things better a la carte as well:

• Removed second contour of SEM: This is unnecessary for the interaction analysis and frankly very confusing to many of our users. Let's reimplement this only if we see demand
• Removed markers on (x, y) location of arms: This cleans up the plot visually quite a bit (especially important when this is small in the interaction analysis) and overall should reduce confusion.

Overall users like looking at these to get a general "vibe" of what the model is doing and I think we should work to preserve visual clarity and reduce noise, even if it may come at the cost of some specificity. If a user really wants to introspect the model precisely they should be using tools other than this contour plot.

Differential Revision: D65233907

[facebook-github-bot]

This pull request was exported from Phabricator. Differential Revision: D65233907

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 91.11111% with 16 lines in your changes missing coverage. Please review.

Project coverage is 95.73%. Comparing base (be8bb34) to head (82b7aab). Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
ax/analysis/plotly/surface/utils.py	47.61%	11 Missing :warning:
ax/analysis/plotly/surface/contour.py	93.61%	3 Missing :warning:
ax/analysis/plotly/surface/slice.py	95.91%	2 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #3095 +/- ## ========================================== - Coverage 95.74% 95.73% -0.02% ========================================== Files 488 494 +6 Lines 49769 49949 +180 ========================================== + Hits 47651 47817 +166 - Misses 2118 2132 +14 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests
• JS Bundle Analysis - Avoid shipping oversized bundles

[facebook-github-bot]

This pull request was exported from Phabricator. Differential Revision: D65233907

[facebook-github-bot]

This pull request was exported from Phabricator. Differential Revision: D65233907

[facebook-github-bot]

This pull request was exported from Phabricator. Differential Revision: D65233907

[facebook-github-bot]

This pull request has been merged in facebook/Ax@3cb26543073bec6f38a4a30a776367c06a3ac6bb.